Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing puzzle theme name in translation XML #16109

Closed
wants to merge 2 commits into from

Conversation

cakiki
Copy link

@cakiki cakiki commented Sep 24, 2024

Add a name node for en passant.

Add a name node for en passant.
@cakiki
Copy link
Author

cakiki commented Sep 24, 2024

This then also affects the translations which are also missing that entry: https://github.com/lichess-org/lila/tree/master/translation/dest/puzzleTheme

@TBestLittleHelper
Copy link
Contributor

I could be wrong, but I think not translating it was a deliberate choice. Since it's the same name across the world. ( Are there exceptions where a local name is used? )

@cakiki
Copy link
Author

cakiki commented Sep 24, 2024

I thought the same at first, but from looking at Wikipedia article translations, I see quite a few languages that use their own expressions for it, like Spanish, Arabic, Ukrainian and Farsi, and almost every language that doesn't use a latin-script alphabet.

@ornicar
Copy link
Collaborator

ornicar commented Sep 24, 2024

we already have that translation there https://github.com/lichess-org/lila/blob/master/translation/source/learn.xml#L158

@ornicar ornicar closed this Sep 24, 2024
@cakiki cakiki deleted the patch-1 branch September 24, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants